Skip to content

Commit

Permalink
Issue/176 amplitude dif (#178)
Browse files Browse the repository at this point in the history
* docstrings, optional argument in quasisep kernels

* Added news doc

* indent, typo and whitespaces fix

* typo fix

* zenodo add

* news, period at the end

* Fixing end of file lint

* Fixing indentation issue

---------

Co-authored-by: Dan Foreman-Mackey <[email protected]>
Co-authored-by: Dan Foreman-Mackey <[email protected]>
  • Loading branch information
3 people authored Aug 23, 2023
1 parent 2bf172d commit 1cc9577
Show file tree
Hide file tree
Showing 3 changed files with 26 additions and 5 deletions.
5 changes: 5 additions & 0 deletions .zenodo.json
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,11 @@
"orcid": "0000-0003-1001-0707",
"affiliation": "Department of Physics and Astronomy, Aarhus University, DK",
"name": "Tronsgaard, René"
},
{
"orcid": "0000-0003-3287-5250",
"affiliation": "Department of Astronomy and the DiRAC Institute, University of Washington, Seattle, WA, USA",
"name": "Caplar, Neven"
}
],
"license": "MIT",
Expand Down
1 change: 1 addition & 0 deletions news/176.doc
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Clarified in documentation that sigma argument is optional in quasisep kernels.
25 changes: 20 additions & 5 deletions src/tinygp/kernels/quasisep.py
Original file line number Diff line number Diff line change
Expand Up @@ -390,7 +390,10 @@ class SHO(Quasisep):
Args:
omega: The parameter :math:`\omega`.
quality: The parameter :math:`Q`.
sigma: The parameter :math:`\sigma`.
sigma (optional): The parameter :math:`\sigma`. Defaults to a value of
1. Specifying the explicit value here provides a slight performance
boost compared to independently multiplying the kernel with a
prefactor.
"""

omega: JAXArray
Expand Down Expand Up @@ -464,7 +467,10 @@ class Exp(Quasisep):
Args:
scale: The parameter :math:`\ell`.
sigma: The parameter :math:`\sigma`.
sigma (optional): The parameter :math:`\sigma`. Defaults to a value of
1. Specifying the explicit value here provides a slight performance
boost compared to independently multiplying the kernel with a
prefactor.
"""

scale: JAXArray
Expand Down Expand Up @@ -498,7 +504,10 @@ class Matern32(Quasisep):
Args:
scale: The parameter :math:`\ell`.
sigma: The parameter :math:`\sigma`.
sigma (optional): The parameter :math:`\sigma`. Defaults to a value of
1. Specifying the explicit value here provides a slight performance
boost compared to independently multiplying the kernel with a
prefactor.
"""
scale: JAXArray
sigma: JAXArray = field(default_factory=lambda: jnp.ones(()))
Expand Down Expand Up @@ -540,7 +549,10 @@ class Matern52(Quasisep):
Args:
scale: The parameter :math:`\ell`.
sigma: The parameter :math:`\sigma`.
sigma (optional): The parameter :math:`\sigma`. Defaults to a value of
1. Specifying the explicit value here provides a slight performance
boost compared to independently multiplying the kernel with a
prefactor.
"""

scale: JAXArray
Expand Down Expand Up @@ -602,7 +614,10 @@ class Cosine(Quasisep):
Args:
scale: The parameter :math:`\ell`.
sigma: The parameter :math:`\sigma`.
sigma (optional): The parameter :math:`\sigma`. Defaults to a value of
1. Specifying the explicit value here provides a slight performance
boost compared to independently multiplying the kernel with a
prefactor.
"""
scale: JAXArray
sigma: JAXArray = field(default_factory=lambda: jnp.ones(()))
Expand Down

0 comments on commit 1cc9577

Please sign in to comment.