Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pdm based build system pre-built wheels #25

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

adehad
Copy link

@adehad adehad commented May 6, 2024

Hi there @dgoeries

Sorry for the unsolicited pull request, I created this pull request to address #24 together with my own needs. Effectively I wanted to create pre-built wheels to reduce the install time and remove the MS Build tools dependency from my pipelines.

Summary of Changes

  1. Build all the wheels in CI
  2. Add windows to the list of os, so a pre-build wheel can be made (could also add macos too at some point)
  3. replace tox (and also wheel) with a pdm based build system to reduce the number of tools needed
  4. Run the tests in CI
  5. The README.txt file was redundant as markdown support is now with pdm and also newer versions of setuptools

The final CI is like so, with a final wheels artifact that can be used to upload to pypi (although the https://github.com/pypa/gh-action-pypi-publish action would be a great way to automate the publishing in if desired):
image

Due to the retention period I have added this link to a successful CI might not show anything:
https://github.com/adehad/lttbc/actions/runs/8972532181

Future suggestions

  1. It may make sense to make a separate CI config that only runs on tags which does all the wheel building, and perhaps only 1 python version and OS is used for every other commit

pyproject.toml Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant