Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: never sign empty set of fields #161

Merged
merged 1 commit into from
Jan 16, 2024
Merged

Conversation

dhensby
Copy link
Owner

@dhensby dhensby commented Dec 8, 2023

The specification is clear that if no headers are listed that the signature should be calculated from the (created) value rather than an empty string. This change fixes that.

NB: in versions <= 10, the Date header is used - if that behaviour is desired, one should specify it explicitly

The specification is clear that if no headers are listed that the signature should be calculated
from the (created) value rather than an empty string. This change fixes that.

NB: in versions <= 10, the Date header is used - if that behaviour is desired, one should specify
it explicitly
@dhensby dhensby merged commit 78dfdad into master Jan 16, 2024
8 checks passed
@dhensby dhensby deleted the pulls/cavage-spec-examples branch January 16, 2024 08:47
Copy link

🎉 This PR is included in version 1.0.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant