Fix claim limit unique key error due to max_visits #388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in get_or_create
hemant10yadav
approved these changes
Sep 5, 2024
calellowitz
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
QA-Ticket
This bug was recently found in QA. The code throws a unique key error because it tries to create an already-created Claim Limit configuration due to the
max_visitsfilter inget_or_create. Themax_visitsare only required when a new ClaimLimit is created, so moving it to thedefaultsparameter ofget_or_createavoids the unique key error and addsmax_visitsspecified to any new claim limits that are created.