Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow specifying user ID on case property for conditional alert recipients #35153

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

AddisonDunn
Copy link
Contributor

@AddisonDunn AddisonDunn commented Sep 27, 2024

Product Description

Jira: https://dimagi.atlassian.net/browse/USH-4811

For the "user specified via case property" recipient option for conditional alerts, this PR enables specifying a user ID (which can be for a web or mobile user) on a case property instead of just a mobile worker username.

Technical Summary

Small change.

Safety Assurance

Safety story

  • Logic of change is well covered by automated tests
  • Small change, confident in the safety of the logic
  • Works on staging!

Automated test coverage

corehq.messaging.scheduling.tests.test_recipients:SchedulingRecipientTest.test_user_id_case_property_recipient

QA Plan

None planned.

Rollback instructions

  • This PR can be reverted after deploy with no further considerations

Labels & Review

  • Risk label is set correctly
  • The set of people pinged as reviewers is appropriate for the level of risk of the change

@AddisonDunn AddisonDunn added the product/all-users-all-environments Change impacts all users on all environments label Sep 27, 2024
@AddisonDunn AddisonDunn marked this pull request as ready for review September 27, 2024 18:45
@AddisonDunn
Copy link
Contributor Author

If you'd read the testing section before now: I actually just learned conditional alerts only send when first created (not upon subsequent saves). Was able to test and confirm on staging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product/all-users-all-environments Change impacts all users on all environments
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant