[B5] Exports: list and download pages #35161
Open
+754
−538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This button pops up a confirmation modal, that's enough.
This is the stanard pattern in HQ. Bonus, it doesn't need js initialization.
.text-warning isn't readable on a white background, be lazy and change it to .text-danger. Shorten the 'Copy & Edit Feed' text so it doesn't spill onto two lines. Remove .btn-link which is a weird affordance, since links don't typically open modals.
This crispy form is just fine.
orangejenny
added
awaiting QA
orangejenny
requested review from
millerdev,
AmitPhulera,
gherceg and
jingcheng16
AmitPhulera
approved these changes
Oct 2, 2024
| @@ -10,6 +10,8 @@ $container-max-widths: ( | |||
| xxl: 1160px | |||
| ); | |||
|
|
|||
| // Spacing override | |||
| $enable-negative-margins: true; | |||
There was a problem hiding this comment.
I don't understand what impact will it have 😅
| @@ -257,7 +257,7 @@ <h4 class="modal-title"> | |||
| class="btn btn-outline-primary btn-sm" | |||
| data-bind="visible: emailedExport.canUpdateData, | |||
| attr: { | |||
| 'data-target': '#modalRefreshExportConfirm-' + id() + '-' + emailedExport.groupId() | |||
| 'data-bs-target': '#modalRefreshExportConfirm-' + id() + '-' + emailedExport.groupId() | |||
There was a problem hiding this comment.
Does this change is flagged by the migration tool?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Product Description
User-facing changes are minimal.
Safety Assurance
Safety story
UI-level changes. Requesting QA.
Automated test coverage
Not much. There are some exports js tests.
QA Plan
Will request QA
Rollback instructions
Labels & Review