Use django-environ to load Env variables #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pxwxnvermx
force-pushed
the
pkv/use-env-variables
branch
from
2f29c4c
to
7bc9a59
Compare
calellowitz
reviewed
Feb 23, 2024
| @@ -6,8 +6,6 @@ | |||
| # | |||
| asgiref==3.6.0 | |||
| # via django | |||
| build==0.10.0 | |||
There was a problem hiding this comment.
do you know why there are so many requirements changes
There was a problem hiding this comment.
Yeah, pip-tools is not in the requirements.in file, so on pip-compile pip-tools and its dependencies were removed.
sravfeyn
reviewed
Apr 29, 2024
connectid/settings.py
Outdated
| TWILIO_AUTH_TOKEN = env("TWILIO_AUTH_TOKEN") | ||
| TWILIO_MESSAGING_SERVICE = env("TWILIO_MESSAGING_SERVICE") | ||
|
|
||
| FCM_CREDENTIALS = env("FCM_CREDENTIALS", default=None) |
There was a problem hiding this comment.
We should probably allow only individual fields within FCM_CREDENTIALs to be configured via env? (instead of the full JSON)
sravfeyn
reviewed
Apr 29, 2024
| @@ -196,10 +197,38 @@ | |||
| "DELETE_INACTIVE_DEVICES": False, | |||
| } | |||
|
|
|||
| from .localsettings import * | |||
There was a problem hiding this comment.
We are missing two settings from prod here CSRF_TRUSTED_ORIGINS and private-key part of OAUTH2_PROVIDER
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added django-environ to load environment variables (db_url, secret etc.) from
.envfiles..env_examplefile lists all the variables that need to be added.