Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add otp generation and sending rate limiting #16

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Add otp generation and sending rate limiting #16

wants to merge 4 commits into from

Conversation

pxwxnvermx
Copy link
Contributor

  • Added a 2-minute time limit before sending the OTP SMS again
  • New OTPs are generated only when the token is valid for 5 more minutes.

@pxwxnvermx pxwxnvermx self-assigned this Feb 16, 2024
calellowitz
calellowitz reviewed Feb 23, 2024
View reviewed changes
Copy link
Collaborator

@calellowitz calellowitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any chance you can add tests for this?

@pxwxnvermx
Copy link
Contributor Author

Yeah, i was working on adding tests for this. Will update this PR with the tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calellowitz calellowitz Awaiting requested review from calellowitz

Assignees

@pxwxnvermx pxwxnvermx

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pxwxnvermx @calellowitz