Run connect-id using Docker #17
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sravfeyn
force-pushed
the
sr/docker
branch
2 times, most recently
from
8b865bb
to
d381b25
Compare
|
@calellowitz This is pretty much working and ready for review. If everything is good here, I can move to Ansible and then Kamal deploy |
|
@calellowitz bump |
calellowitz
reviewed
May 14, 2024
Dockerfile
Outdated
|
|
||
| # copy entrypoint.sh | ||
| COPY ./entrypoint.sh /vendor/entrypoint.sh | ||
| RUN sed -i 's/\r$//g' /vendor/entrypoint.sh |
There was a problem hiding this comment.
Why is this line necessary? Looks like it remove carriage returns, which I wouldn't think the file has
There was a problem hiding this comment.
Yes, it can be removed. It's no longer necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.