Clarify if sessions are resumable for each gateway close code #7172
+17
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure why the CI fails on the table formatting, everything is correctly aligned when pasting it in an editor with a fixed-width font. |
I think you have a double space at the end of the second row from the right |
|
I think it makes more sense to have the table split into two columns: So it'd look something like
|
|
Yeah, I hesitated, but a single I'm updating the PR to use 2 columns. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR (which was made after this DDevs thread) attempts to clarify which gateway close codes are potentially resumable, and which ones are not worth trying to resume.
The idea is that libs can immediately reset the shard's session state upon encountering a non-resumable close code, saving a useless connection to the
gateway_resume_url.The information on whether a close code is resumable or not is based solely on my own testing (except for 4001, which has been confirmed to never be resumable by @mrkirby153 in the aforementioned thread).