Skip to content
This repository has been archived by the owner on Dec 24, 2021. It is now read-only.

DurationArgumentType #256

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

MADLAB96
Copy link

@MADLAB96 MADLAB96 commented Apr 1, 2019

#182 Added Duration type.
Takes a string in this format: 1mo2w3d4h5m6s7ms or 1mo 2w 3d 4h 5m 6s 7ms.

The issue mentioned having methods for this type but I don't believe they can be accessed. If I'm wrong about that, it would be a quick to add them back in.

Copy link
Contributor

@jonahsnider jonahsnider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are several lint issues with the usage of the var keyword. There's also incorrect checking of NaN values that should be fixed. My suggestions resolve these issues.

src/types/duration.js Outdated Show resolved Hide resolved
src/types/duration.js Outdated Show resolved Hide resolved
src/types/duration.js Outdated Show resolved Hide resolved
src/types/duration.js Outdated Show resolved Hide resolved
src/types/duration.js Outdated Show resolved Hide resolved
src/types/duration.js Outdated Show resolved Hide resolved
src/types/duration.js Outdated Show resolved Hide resolved
@MADLAB96
Copy link
Author

MADLAB96 commented Apr 2, 2019

I'll make those changes. None of these popped up from npm test or npm run lint for me.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants