DEV: partially bake in env #875
Open
+113
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
featheredtoast
force-pushed
the
default-bake-env
branch
from
bd9a4ca
to
8546d96
Compare
It may be useful for launcher2 build to bake in some env, allowing for default env to run from a built image. Introduce defaultBakeEnv as a list of env to bake into images. This allows for folks pulling images to not need to mark every env variable, allowing for some convenience in starting images.
featheredtoast
force-pushed
the
default-bake-env
branch
from
8546d96
to
27b21f4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It may be useful for launcher2 build to bake in some env, allowing for default env to run from a built image.
Introduce defaultBakeEnv as a list of env to bake into images. This allows for folks pulling images to not need to mark every env variable, allowing for some convenience in starting images.