SYCL. Add some basic functional for sycl implementation of partition builder. #10011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
napetrov
reviewed
Jan 26, 2024
napetrov
reviewed
Jan 26, 2024
| target_link_libraries(plugin_sycl_test PUBLIC -fsycl) | ||
|
|
||
| set_target_properties(plugin_sycl_test PROPERTIES | ||
| COMPILE_FLAGS -fsycl |
There was a problem hiding this comment.
should we also have "-fsycl-device-code-split=per_kernel" as options?
There was a problem hiding this comment.
should we also have "-fsycl-device-code-split=per_kernel" as options?
I didn't observe any perf differences, at least for the last compiler.
trivialfis
approved these changes
Jan 31, 2024
This was referenced Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I continue adding of
syclsupport (#9691, #9846, #9800).By this PR I am starting adding the training in the
sycldevices. All training is to large for a single PR. For that reason I plan to add it step by step together with the related tests. Here I add some basic logic related toPartitionBuilder.This PR itself doesn't add any new functional, but I plan to combine all related parts one by one to a launchable sycl-training.
I have also made some changes in sycl-related CMakeFile to build sycl tests with icpx.