test: global force exit #5182
Open
test: global force exit #5182
+100
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alano Terblanche <[email protected]>
Benehiko
force-pushed
the
global-force-exit-test
branch
from
b148d30
to
dddf757
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5182 +/- ##
==========================================
+ Coverage 61.29% 61.78% +0.49%
==========================================
Files 294 297 +3
Lines 20773 20781 +8
==========================================
+ Hits 12733 12840 +107
+ Misses 7123 7027 -96
+ Partials 917 914 -3 |
|
Seems like I forgot to squash the commits on this PR, which lead to this being committed into master and then subsequently removed in a follow-up commit 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Testing global signal handling in the CLI.
- How I did it
Reusing
go testto execute some parts of the CLI and verify the exit code on SIGINT.- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)