scout: ootb policy → policy types #21028
Conversation
github-actions
bot
added
area/build
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
dvdksn
requested review from
dansmithy,
chrispatrick,
Daniel-Kolev and
tazin-docker
dvdksn
force-pushed
the
scout-policy-no-custom-ootb
branch
3 times, most recently
from
3e67564
to
aeaee7a
Compare
| - If the **Configure** button is grayed out, it means the selected policy | ||
| has no configurable parameters. |
There was a problem hiding this comment.
thought: Just want to mention that the button being greyed out also means that the user already has an existing policy. We are not allowing users to create a new policy with the same configuration - they will just have two or more policies that do the same thing. The button will not be grayed out if they have deleted that policy so they can re-create it if they need to.
Don't know if it's worth mentioning any of this.
There was a problem hiding this comment.
I just added a section on how to recover deleted policies... hopefully that covers this case.
dvdksn
force-pushed
the
scout-policy-no-custom-ootb
branch
from
aeaee7a
to
4070c89
Compare
| @@ -109,31 +117,32 @@ The following policy parameters are configurable in a custom version: | |||
|
|
|||
| For more information about configuring policies, see [Configure policies](./configure.md). | |||
|
|
|||
| ### No AGPL v3 licenses | |||
| ### Compliant Licenses | |||
There was a problem hiding this comment.
thought (non-blocking): I've noticed some of the policy types do mention their default configuration but this one doesn't. We should probably include a description here and any other policy that don't mention what it does by default. Another proposal is to take those descriptions into a new section that describes the default set of policies that new orgs get. Should keep things separated. Maybe as a next step. Don't want to block this PR.
Signed-off-by: David Karlsson <[email protected]>
dvdksn
force-pushed
the
scout-policy-no-custom-ootb
branch
from
4070c89
to
4976dae
Compare
dvdksn
changed the title
| reflect internal requirements and standards. You can also disable a policy | ||
| altogether if it isn't relevant to you. For more information, see [Configure | ||
| policies](./configure.md). | ||
| - [Severity-Based Vulnerability](#severity-based-vulnerability) |
There was a problem hiding this comment.
@dvdksn Looks like the policy names are in sentence case on the Scout website, but they are in title case here. Is this intentional?
There was a problem hiding this comment.
yes, these type names are not published yet
There was a problem hiding this comment.
That's right. We haven't yet deployed the FE changes. Future values are based on this notion doc and some of these do not align. For example:
"Severity-Based Vulnerability" -> "Severity-based Vulnerability"
"Up-to-Date Base Images" -> "Up-to-date Base Images"
Haven't checked all.
There was a problem hiding this comment.
Also can you update any other place they are shown (titles as well)
Description
Changes how policies are configured, updates naming from ootb policies to "default configurations" and "policy types"