Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added deploy nopcommerce on azure app service #152

Merged
merged 1 commit into from
Oct 24, 2021
Merged

added deploy nopcommerce on azure app service #152

merged 1 commit into from
Oct 24, 2021

Conversation

ninefyi
Copy link
Contributor

@ninefyi ninefyi commented Oct 10, 2021

Hi, I created issue #151. Please let me know if I have anything wrong.

@ninefyi ninefyi marked this pull request as draft October 11, 2021 04:05
@ninefyi ninefyi marked this pull request as ready for review October 11, 2021 04:06
@aaronamm aaronamm added the hacktoberfest-accepted Approved pull request for Hacktoberfest label Oct 11, 2021
@aaronamm
Copy link
Member

@ninefyi Thank you so your contribution.

However, I think it would be nice if you could separated this document in to two documents.

  • 1st document, just use simple setup Azure SQL database, App Service, Storage and nopCommerce. I think it will simplify our document and it is easy for a beginner to follow.
  • 2nd document, add more secured infra by using private network.

Thanks.

@ninefyi
Copy link
Contributor Author

ninefyi commented Oct 11, 2021

@aaronamm Sure, I will follow your comment.

@aaronamm aaronamm self-assigned this Oct 13, 2021
@aaronamm aaronamm self-requested a review October 13, 2021 06:04
@mildronize
Copy link
Collaborator

I think I should be better if you can add some brief explanation what happen in each step. I will be more easy for audience to catch up the content. @ninefyi

@ninefyi
Copy link
Contributor Author

ninefyi commented Oct 16, 2021

I already changed to create the simple way installation first. It is a better way to follow up for simple installation. Could you please review and let me know any feedback. @mildronize @aaronamm

aaronamm
aaronamm requested changes Oct 24, 2021
View reviewed changes
Copy link
Member

@aaronamm aaronamm left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ninefyi I have checked out your PR and it look good.
The content focus on screenshot that we can later improve it by adding more description but we don't need to do in this PR.

However, since this is a small PR, could you please squash all commits and make this PR to have only commit.

Thanks.

FYI here is a screenshot from of this PR content when rending in a browser.

image

@ninefyi @pitichampeethong
added deploy nopcommerce on azure app service
2a25b7b 
updated: using the easy way for nopcommerce installation

added screenshot for install step of nopCommerce

updated refactor images
@ninefyi ninefyi force-pushed the feature/deploy-nopcommerce-on-azure-app-service branch from 0d73812 to 2a25b7b Compare October 24, 2021 13:28
@ninefyi
Copy link
Contributor Author

ninefyi commented Oct 24, 2021

@aaronamm I already merge all commits into one commit. Could you please check again and let me know?

@aaronamm
Copy link
Member

@ninefyi Thanks for squash multiple commits.

@aaronamm aaronamm merged commit 3841d63 into dotnetthailand:main Oct 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaronamm aaronamm aaronamm approved these changes

Assignees

@aaronamm aaronamm

Labels
hacktoberfest-accepted Approved pull request for Hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ninefyi @aaronamm @mildronize