Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add unit test for dfget #748

Merged
merged 1 commit into from
Sep 24, 2024
Merged

test: add unit test for dfget #748

merged 1 commit into from
Sep 24, 2024

Conversation

Lzzzzzt
Copy link
Contributor

@Lzzzzzt Lzzzzzt commented Sep 23, 2024

Add unit tests for util function in dfget.

Description

This PR is done by finishing the following tasks:

  • Add unit tests for validate_args.
  • Add unit tests for make_output_by_entry

Related Issue

#496

Motivation and Context

Dragonfly rust client does not support back-to-source downloading of different object storage protocols. Priority is given to supporting OSS protocol back-to-source downloads. Need to support OSS protocol in dragonfly-client-backend crate, implemented based on trait Backend and it needs to support directory recursive downloading.

Copy link

codecov bot commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 25.91%. Comparing base (e2209a8) to head (a2d4b1f).
Report is 6 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #748      +/-   ##
==========================================
+ Coverage   23.45%   25.91%   +2.46%     
==========================================
  Files          55       55              
  Lines        7337     7493     +156     
==========================================
+ Hits         1721     1942     +221     
+ Misses       5616     5551      -65     
Files with missing lines Coverage Δ
dragonfly-client/src/bin/dfget/main.rs 28.02% <100.00%> (+28.02%) ⬆️

... and 2 files with indirect coverage changes

Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaius-qi gaius-qi merged commit c7a7c66 into dragonflyoss:main Sep 24, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants