-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature : Typography #55
Conversation
…rating typography class
@@ -0,0 +1,45 @@ | |||
# Typography | |||
This is a simple doc that should be used in line with the typography tokens in the design system |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replace with:
These are the typography tokens in the design system.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done...
Example: | ||
If you have an app with two screens, characters and character, where characters shows a list of people and character shows the details of one person. | ||
You can use title for Characters and Character . | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing code sample.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done...
|
||
### Display | ||
This is the token to use when you want to highlight or make any content stand out. It should not be used as a header, title or body text. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing code sample. for the others
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done...
import com.droidconke.chai.utils.ChaiPreview | ||
|
||
private val DUMMY_CHAI_TEXT = "Design systems provide guidelines and reusable components to ensure consistent and efficient design across digital products, improving user experience and streamlining team workflows." | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it make sense to use an inline doc here... showing how we use the specific composable
@@ -27,8 +27,7 @@ import androidx.compose.ui.text.style.TextAlign | |||
import androidx.compose.ui.text.style.TextOverflow | |||
import androidx.compose.ui.unit.sp | |||
import com.droidconke.chai.atoms.* | |||
import com.droidconke.chai.atoms.MontserratRegular | |||
import com.droidconke.chai.atoms.MontserratThin | |||
import com.droidconke.chai.atoms.MontserratSans | |||
import com.droidconke.chai.chaiColorsPalette | |||
|
|||
/** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this inline doc up to date?
…nes, configures button tokens
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
waiting. @MamboBryan :)
name: Pull request
about: Create a pull request
label: 'triage me'
Fixes #53
Fixes #60
How can this PR be tested?
Thank you for opening a Pull Request!
Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
./gradlew --init-script gradle/init.gradle.kts spotlessApply
to automatically apply formatting)Is this your first Pull Request?
./tools/setup.sh
Fixes #<issue_number_goes_here> 🦕
Screenshot