Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

34 create hilt convention plugin #147

Merged
merged 7 commits into from
Jul 17, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 1 addition & 9 deletions app/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,7 @@
plugins {
id("com.android.application")
id("org.jetbrains.kotlin.android")
id("dagger.hilt.android.plugin")
kotlin("kapt")
id("droidconke.android.hilt")
id("com.google.gms.google-services")
id("com.google.firebase.crashlytics")
id("com.google.firebase.firebase-perf")
Expand Down Expand Up @@ -81,19 +80,12 @@ dependencies {
implementation(libs.android.appCompat)
implementation(libs.android.material)

implementation(libs.android.hilt)
kapt(libs.android.hilt.compiler)

implementation(libs.timber)

androidTestImplementation(libs.android.test.junit4)
androidTestImplementation(libs.android.test.espresso)
androidTestImplementation(libs.android.hilt.testing)
kaptAndroidTest(libs.android.hilt.compiler)

testImplementation(libs.bundles.test)
testImplementation(libs.android.hilt.compiler)
kaptTest(libs.android.hilt.compiler)

implementation(platform(libs.firebase.bom))
implementation(libs.bundles.firebase)
Expand Down
4 changes: 4 additions & 0 deletions build-logic/convention/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -31,5 +31,9 @@ gradlePlugin {
id = "droidconke.android.room"
implementationClass = "AndroidRoomConventionPlugin"
}
register("androidHilt") {
id = "droidconke.android.hilt"
implementationClass = "AndroidHiltConventionPlugin"
}
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,42 @@
/* Copyright 2022 The Android Open Source Project
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/


import com.android254.libs
import org.gradle.api.Plugin
import org.gradle.api.Project
import org.gradle.kotlin.dsl.dependencies

class AndroidHiltConventionPlugin : Plugin<Project> {
override fun apply(target: Project) {
with(target) {
with(pluginManager) {
apply("dagger.hilt.android.plugin")
apply("org.jetbrains.kotlin.kapt")
misshannah marked this conversation as resolved.
Show resolved Hide resolved
}

dependencies {
"implementation"(libs.findLibrary("android.hilt").get())
"implementation"(libs.findLibrary("android.hilt.navigation.compose").get())
"kapt"(libs.findLibrary("android.hilt.androidx.compiler").get())
"kapt"(libs.findLibrary("android.hilt.compiler").get())
"kaptAndroidTest"(libs.findLibrary("android.hilt.compiler").get())
"kaptTest"(libs.findLibrary("android.hilt.compiler").get())
"androidTestImplementation"(libs.findLibrary("android.hilt.testing").get())
"testImplementation"(libs.findLibrary("android.hilt.compiler").get())
}
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -14,16 +14,15 @@
* limitations under the License.
*/

import com.android254.libs
import com.google.devtools.ksp.gradle.KspExtension
import org.gradle.api.Plugin
import org.gradle.api.Project
import org.gradle.api.artifacts.VersionCatalogsExtension
import org.gradle.api.tasks.InputDirectory
import org.gradle.api.tasks.PathSensitive
import org.gradle.api.tasks.PathSensitivity
import org.gradle.kotlin.dsl.configure
import org.gradle.kotlin.dsl.dependencies
import org.gradle.kotlin.dsl.getByType
import org.gradle.process.CommandLineArgumentProvider
import java.io.File

Expand All @@ -39,8 +38,6 @@ class AndroidRoomConventionPlugin : Plugin<Project> {
arg(RoomSchemaArgProvider(File(projectDir, "schemas")))
}

val libs = extensions.getByType<VersionCatalogsExtension>().named("libs")

dependencies {
add("implementation", libs.findLibrary("room.runtime").get())
add("implementation", libs.findLibrary("room.ktx").get())
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,8 @@ package com.android254
import com.android.build.api.dsl.CommonExtension
import org.gradle.api.JavaVersion
import org.gradle.api.Project
import org.gradle.api.artifacts.VersionCatalogsExtension
import org.gradle.api.plugins.ExtensionAware
import org.gradle.kotlin.dsl.dependencies
import org.gradle.kotlin.dsl.getByType
import org.gradle.kotlin.dsl.provideDelegate
import org.jetbrains.kotlin.gradle.dsl.KotlinJvmOptions

Expand Down Expand Up @@ -63,8 +61,6 @@ internal fun Project.configureKotlinAndroid(
}
}

val libs = extensions.getByType<VersionCatalogsExtension>().named("libs")

dependencies {
add("implementation", libs.findLibrary("android.coreKtx").get())

Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
package com.android254

import org.gradle.api.Project
import org.gradle.api.artifacts.VersionCatalog
import org.gradle.api.artifacts.VersionCatalogsExtension
import org.gradle.kotlin.dsl.getByType

val Project.libs
get(): VersionCatalog = extensions.getByType<VersionCatalogsExtension>().named("libs")
5 changes: 1 addition & 4 deletions data/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,8 @@
plugins {
id("droidconke.android.library")
id("droidconke.android.room")
kotlin("kapt")
id("droidconke.android.hilt")
kotlin("plugin.serialization")
id("com.google.dagger.hilt.android")
id("org.jlleitschuh.gradle.ktlint")
id("io.gitlab.arturbosch.detekt")
}
Expand Down Expand Up @@ -46,9 +45,7 @@ dependencies {
implementation(libs.android.appCompat)
implementation(libs.android.material)
api(libs.kotlin.coroutines.datetime)
implementation(libs.android.hilt)
implementation(libs.timber)
kapt(libs.android.hilt.compiler)
implementation(libs.datastore)
implementation(libs.kotlin.coroutines.android)
implementation(libs.ktor.core)
Expand Down
7 changes: 1 addition & 6 deletions presentation/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,7 @@
*/
plugins {
id("droidconke.android.library")
id("dagger.hilt.android.plugin")
kotlin("kapt")
id("droidconke.android.hilt")
id("org.jlleitschuh.gradle.ktlint")
id("io.gitlab.arturbosch.detekt")
}
Expand Down Expand Up @@ -76,7 +75,6 @@ dependencies {
implementation(libs.bundles.compose)
implementation(libs.lifecycle.runtimeKtx)
implementation(libs.timber)
implementation(libs.android.hilt)
implementation(libs.androidx.splashscreen)
implementation(libs.kotlin.coroutines.play.services)
implementation(libs.gms.play.services.auth)
Expand All @@ -86,9 +84,6 @@ dependencies {
implementation(libs.accompanist.swiperefresh)
implementation(libs.kotlin.coroutines.datetime)
implementation(libs.compose.lifecycle.runtime)
kapt(libs.android.hilt.compiler)
implementation(libs.android.hilt.navigation.compose)
kapt(libs.android.hilt.androidx.compiler)
debugImplementation(libs.compose.ui.tooling)
debugImplementation(libs.compose.ui.test.manifest)

Expand Down
Loading