Alias @value to @exception in Try::Error #177
Open
+52
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows deconstruct to work correctly
flash-gordon
requested changes
Jul 23, 2024
spec/unit/try_spec.rb
Outdated
Comment on lines
60
to
62
| it "deconstructs to the value" do | ||
| expect(subject.deconstruct).to eq ["foo"] | ||
| end |
There was a problem hiding this comment.
can you please test it with pattern matching rather than hitting .deconstruct directly? It's done like this in other tests. Also equality is checked via eql rather than eq
There was a problem hiding this comment.
Thanks for your review @flash-gordon - please see 9caca77
alexkalderimis
force-pushed
the
alexkalderimis-try-error-deconstruct
branch
from
9caca77
to
2f35d4c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows deconstruct to work correctly
Fixes: #176