Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revised dune port of findlib.1.8.1+dune2 #111

Closed
wants to merge 1 commit into from
Closed

Revised dune port of findlib.1.8.1+dune2 #111

wants to merge 1 commit into from

Conversation

Leonidas-from-XIV
Copy link
Contributor

No description provided.

@samoht
Copy link
Contributor

samoht commented Mar 25, 2022

lint is failing:

opam uses dune: Failed: Not using `dune` in build
opam uses dune: Failed: Not using `dune` in build
Linting ocamlfind.1.8.1+dune2
Linting project: Ok
dune-project exists: Ok
Parsing dune-project: Ok
Version is correct: Ok
opam uses dune: Failed: Not using `dune` in build
opam uses dune: Failed: Not using `dune` in build

samoht
samoht reviewed Mar 25, 2022
View reviewed changes
packages/findlib/findlib.1.8.1+dune2/opam
bug-reports: "https://github.com/dune-universe/lib-findlib/issues"
dev-repo: "git+https://github.com/dune-universe/lib-findlib.git"
build: [
[ "env" "FINDLIB_PREFIX=%{lib}%" "dune" "build" "-p" name "-j" jobs ]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we really need to have FINDLIB_PREFIX here? We are not building this with opam anyway...

@Leonidas-from-XIV
Copy link
Contributor Author

I'll close this PR since it probably makes more sense to just do a fresh port of a new ocamlfind release and tick off that box in #125.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samoht samoht samoht left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Leonidas-from-XIV @samoht