-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update feeds | add base | create ocr macro #5878
base: main
Are you sure you want to change the base?
Conversation
AnonJon
commented
May 3, 2024
- Update existing feeds and operators
- Add Base to feeds
- Start new OCR chainlink macro
Workflow run id 8944063611 approved. |
Workflow run id 8944063745 approved. |
Workflow run id 8944266428 approved. |
Workflow run id 8944266569 approved. |
Workflow run id 8951006095 approved. |
Workflow run id 8951006127 approved. |
Workflow run id 8951123007 approved. |
Workflow run id 8951123154 approved. |
Workflow run id 8951152678 approved. |
Workflow run id 8951152686 approved. |
Workflow run id 8951304480 approved. |
Workflow run id 8951304543 approved. |
Workflow run id 8951323833 approved. |
Workflow run id 8951323801 approved. |
Workflow run id 8951334501 approved. |
Workflow run id 8951334525 approved. |
Workflow run id 8951367539 approved. |
Workflow run id 8951367561 approved. |
Workflow run id 8951486464 approved. |
Workflow run id 8951486492 approved. |
Workflow run id 8951526229 approved. |
Workflow run id 8951526172 approved. |
1b5177a
to
41fdaae
Compare
Workflow run id 8951889028 approved. |
Workflow run id 8951888978 approved. |
Workflow run id 8976845045 approved. |
Workflow run id 8976845318 approved. |
Workflow run id 8977439567 approved. |
wow! thank you for refactoring your code with this approach, it's much appreciated. the refactor all looks good, i'm just going to hold off for a second so we can dig into the performance on some of the incremental models. it's actually something i've wanted to do for a bit, as the runtimes in prod are a bit slow too. we are likely just missing a few filters / join conditions / something along those lines in one or two macros. i'm happy to help dig into those long running ones and help here in a bit. in case you're not following what i'm referring to, if you expand the runtime of the gh action for CI run(s) on the incremental run step, you'll see some long running models. ideally most of the incremental step runs are much shorter than hundreds of seconds. some that i'd like to look closer at:
|
Yeah, no rush on my side so if we can make these more efficient that would be great. Ill take a look into the ones you listed and see how they could be updated. Cheers |
Workflow run id 9068062212 approved. |
Workflow run id 9068062351 approved. |
thanks for taking an initial look and helping decrease incremental time a bit already 🙏 i'll be out until early next week, do you need me to merge this before i'm out or can this sit more until late next week? |
Next week is fine. Ill take some more time with it before then and see if I can make them faster. |
fyi, as noted in gh discussion that i tagged you, these models have moved in the directory. if you wanted to rebase the branch and get it up to date, we can try to continue this soon. |
4abb4e3
to
3d13d59
Compare
Workflow run id 9664638090 approved. |
Workflow run id 9664638296 approved. |
Workflow run id 9664638297 approved. |
@jeff-dude rebased everything to new layout |
3d13d59
to
0d15e0e
Compare
Workflow run id 9942549759 approved. |
Workflow run id 9942550057 approved. |
Workflow run id 9942550065 approved. |
Workflow run id 9945396114 approved. |
Workflow run id 9945396364 approved. |
Workflow run id 9945396362 approved. |