Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update feeds | add base | create ocr macro #5878

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

AnonJon
Copy link
Contributor

@AnonJon AnonJon commented May 3, 2024

  • Update existing feeds and operators
  • Add Base to feeds
  • Start new OCR chainlink macro

@dune-eng
Copy link

dune-eng commented May 3, 2024

Workflow run id 8944063611 approved.

@dune-eng
Copy link

dune-eng commented May 3, 2024

Workflow run id 8944063745 approved.

@dune-eng
Copy link

dune-eng commented May 3, 2024

Workflow run id 8944266428 approved.

@dune-eng
Copy link

dune-eng commented May 3, 2024

Workflow run id 8944266569 approved.

@dune-eng
Copy link

dune-eng commented May 4, 2024

Workflow run id 8951006095 approved.

@dune-eng
Copy link

dune-eng commented May 4, 2024

Workflow run id 8951006127 approved.

@dune-eng
Copy link

dune-eng commented May 4, 2024

Workflow run id 8951123007 approved.

@dune-eng
Copy link

dune-eng commented May 4, 2024

Workflow run id 8951123154 approved.

@dune-eng
Copy link

dune-eng commented May 4, 2024

Workflow run id 8951152678 approved.

@dune-eng
Copy link

dune-eng commented May 4, 2024

Workflow run id 8951152686 approved.

@AnonJon AnonJon changed the title update feeds | add base | create ocr macro WIP: update feeds | add base | create ocr macro May 4, 2024
@dune-eng
Copy link

dune-eng commented May 4, 2024

Workflow run id 8951304480 approved.

@dune-eng
Copy link

dune-eng commented May 4, 2024

Workflow run id 8951304543 approved.

@dune-eng
Copy link

dune-eng commented May 4, 2024

Workflow run id 8951323833 approved.

@dune-eng
Copy link

dune-eng commented May 4, 2024

Workflow run id 8951323801 approved.

@dune-eng
Copy link

dune-eng commented May 4, 2024

Workflow run id 8951334501 approved.

@dune-eng
Copy link

dune-eng commented May 4, 2024

Workflow run id 8951334525 approved.

@dune-eng
Copy link

dune-eng commented May 4, 2024

Workflow run id 8951367539 approved.

@dune-eng
Copy link

dune-eng commented May 4, 2024

Workflow run id 8951367561 approved.

@dune-eng
Copy link

dune-eng commented May 4, 2024

Workflow run id 8951486464 approved.

@dune-eng
Copy link

dune-eng commented May 4, 2024

Workflow run id 8951486492 approved.

@dune-eng
Copy link

dune-eng commented May 4, 2024

Workflow run id 8951526229 approved.

@dune-eng
Copy link

dune-eng commented May 4, 2024

Workflow run id 8951526172 approved.

@dune-eng
Copy link

dune-eng commented May 4, 2024

Workflow run id 8951889028 approved.

@dune-eng
Copy link

dune-eng commented May 4, 2024

Workflow run id 8951888978 approved.

@jeff-dude jeff-dude added the WIP work in progress label May 6, 2024
@dune-eng
Copy link

dune-eng commented May 6, 2024

Workflow run id 8976845045 approved.

@dune-eng
Copy link

dune-eng commented May 6, 2024

Workflow run id 8976845318 approved.

@dune-eng
Copy link

dune-eng commented May 7, 2024

Workflow run id 8977439567 approved.

@jeff-dude jeff-dude added in review Assignee is currently reviewing the PR and removed ready-for-review this PR development is complete, please review labels May 13, 2024
@jeff-dude
Copy link
Member

wow! thank you for refactoring your code with this approach, it's much appreciated.

the refactor all looks good, i'm just going to hold off for a second so we can dig into the performance on some of the incremental models. it's actually something i've wanted to do for a bit, as the runtimes in prod are a bit slow too. we are likely just missing a few filters / join conditions / something along those lines in one or two macros. i'm happy to help dig into those long running ones and help here in a bit.

in case you're not following what i'm referring to, if you expand the runtime of the gh action for CI run(s) on the incremental run step, you'll see some long running models. ideally most of the incremental step runs are much shorter than hundreds of seconds.

some that i'd like to look closer at:

  • ocr_reward_evt_transfer_daily
  • ocr_fulfilled_transactions

@AnonJon
Copy link
Contributor Author

AnonJon commented May 13, 2024

Yeah, no rush on my side so if we can make these more efficient that would be great. Ill take a look into the ones you listed and see how they could be updated. Cheers

@dune-eng
Copy link

Workflow run id 9068062212 approved.

@dune-eng
Copy link

Workflow run id 9068062351 approved.

@jeff-dude
Copy link
Member

Yeah, no rush on my side so if we can make these more efficient that would be great. Ill take a look into the ones you listed and see how they could be updated. Cheers

thanks for taking an initial look and helping decrease incremental time a bit already 🙏

i'll be out until early next week, do you need me to merge this before i'm out or can this sit more until late next week?

@AnonJon
Copy link
Contributor Author

AnonJon commented May 15, 2024

Next week is fine. Ill take some more time with it before then and see if I can make them faster.

@jeff-dude jeff-dude added the WIP work in progress label May 15, 2024
@jeff-dude
Copy link
Member

fyi, as noted in gh discussion that i tagged you, these models have moved in the directory. if you wanted to rebase the branch and get it up to date, we can try to continue this soon.

@dune-eng
Copy link

Workflow run id 9664638090 approved.

@dune-eng
Copy link

Workflow run id 9664638296 approved.

@dune-eng
Copy link

Workflow run id 9664638297 approved.

@AnonJon
Copy link
Contributor Author

AnonJon commented Jun 25, 2024

@jeff-dude rebased everything to new layout

@dune-eng
Copy link

Workflow run id 9942549759 approved.

@dune-eng
Copy link

Workflow run id 9942550057 approved.

@dune-eng
Copy link

Workflow run id 9942550065 approved.

@dune-eng
Copy link

Workflow run id 9945396114 approved.

@dune-eng
Copy link

Workflow run id 9945396364 approved.

@dune-eng
Copy link

Workflow run id 9945396362 approved.

@jeff-dude jeff-dude added ready-for-final-review and removed WIP work in progress in review Assignee is currently reviewing the PR labels Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants