-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Paraswap Ethereum trades #6581
base: main
Are you sure you want to change the base?
Fix Paraswap Ethereum trades #6581
Conversation
…ok into fix-paraswap-base-trades
…raswap-base-trades
Split tables for trades by version and project to get more precise trade data using data specific for each table; Replace inner join to left join and remove is_eth condition: for ETH/ERC20 is_eth for token_in was true and for token_out was false. Later inner join just filtered such transactions. Also token_out has had two is_eth = false conditions which filtered all transactions that included ETH.
…raswap-ethereum-trades
…llbook into fix-paraswap-ethereum-trades
Workflow run id 10469285857 approved. |
Workflow run id 10469286205 approved. |
Workflow run id 10469318035 approved. |
Workflow run id 10469318314 approved. |
Workflow run id 10529589658 approved. |
Workflow run id 10529589305 approved. |
…raswap-ethereum-trades
Workflow run id 10529607018 approved. |
Workflow run id 10529607335 approved. |
Workflow run id 10560412413 approved. |
Workflow run id 10560412206 approved. |
Add checking for TokenTransferProxy because "event from" is not always Augustus caller
b4f6300
to
e2da218
Compare
Workflow run id 10562598893 approved. |
Workflow run id 10562599195 approved. |
Workflow run id 10834477682 approved. |
Workflow run id 10834478066 approved. |
Workflow run id 10836272680 approved. |
Workflow run id 10836272861 approved. |
Workflow run id 10844349374 approved. |
Workflow run id 10844349650 approved. |
Workflow run id 10844519418 approved. |
Workflow run id 10844519802 approved. |
Workflow run id 10878968779 approved. |
Workflow run id 10878968911 approved. |
Workflow run id 10881955984 approved. |
Workflow run id 10881956342 approved. |
Workflow run id 10882039727 approved. |
Workflow run id 10882039493 approved. |
Workflow run id 10887639134 approved. |
Workflow run id 10887639621 approved. |
Workflow run id 10887654578 approved. |
Workflow run id 10887654745 approved. |
…raswap-ethereum-trades
Workflow run id 10897575330 approved. |
Workflow run id 10897575517 approved. |
Thank you for contributing to Spellbook 🪄
Update!
Please build spells in the proper subproject directory. For more information, please see the main readme, which also links to a GH discussion with the option to ask questions.
Contribution type
Please check the type of contribution this pull request is for:
For bug fixes
If you are fixing a bug, please provide the following information:
is_eth
condition, which wastrue
for bothswap_detail_in
andswap_detail_out
in ETH/ERC20 transactions. This causedinner join
to filter out these transactions. Also,swap_detail_out
had twois_eth = false
conditions, which was filtering out all transactions that start or end from ETH.is_eth
condition and replacedunion all
withleft join
andcoalesce
.Thank you for your contribution!