Pre-check the file path before disk access #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check that the path is valid to make sure that's it's not being manipulated.
|
I tested this by running the server but not 100% sure on it. do we need to merge into other branches? Don't need this code exactly btw, I think just having a comment "don't do this" would also work. |
|
I think it would need to go into the other branches... but I also don't feel too worried about this being left unchecked. Maybe we should instead add some disclaimer in the README to consider this demoware and production-readiness needs to be considered in all of the server and example wasm code used. Your call though! Thanks for looking into this. |
nilslice
approved these changes
Sep 17, 2024
|
I think if we really want to do this, it needs to be applied to all the other branches (which are incremental steps through the guide) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check that the path is valid to make sure that's it's not being manipulated.