Merge pull request #1 from dyte-in/fix/capps-3042-aws-transcribe-changes

fix(build): type dependency was causing build failure for server
dyte-io · Jul 6, 2023 · bdc3dc1 · bdc3dc1
2 parents 0654cc6 + ca11e6d
commit bdc3dc1
Show file tree

Hide file tree

Showing 4 changed files with 23 additions and 2 deletions.
diff --git a/README.md b/README.md
@@ -12,7 +12,7 @@ Once done, download the key containing your accessKeyId, secretAccessKey from th
 
 To keep things simple, in this repo, you will be asked to put keys in .env file. Please alter the code as per the security standards of your application.
 
-<b>Note:</b> Without having accessKeyId & secretAccessKey, this repo may not work properly.
+<b>Note:</b> Without having accessKeyId & secretAccessKey, this repo may not work, locally.
 
 
 # How to use

diff --git a/client/src/AWSTranscribe.ts b/client/src/AWSTranscribe.ts
@@ -209,7 +209,7 @@ class AWSTranscribe {
                 transcript = decodeURIComponent(escape(transcript));
 
                 if (this.translate) {
-                    const translationResponse = await fetch(`${this.translationEndpoint}?sourceLanguageCode=${this.source}&targetLanguageCode=${this.target}&text=${transcript}`);
+                    const translationResponse = await fetch(`${this.translationEndpoint}?sourceLanguageCode=${this.source}&targetLanguageCode=${this.target}&text=${encodeURIComponent(transcript)}`);
                     transcript = (await translationResponse.json()).data.translatedText;
                 }
 

diff --git a/package-lock.json b/package-lock.json
diff --git a/server/package.json b/server/package.json
@@ -20,6 +20,7 @@
     "query-string": "^6.0.0"
   },
   "devDependencies": {
+    "@types/cors": "^2.8.13",
     "@types/express": "^4.17.13",
     "@types/query-string": "^6.3.0",
     "ts-node": "^10.8.2",