-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[24] Create Java 24 constants and test framework changes #2905 #3015
base: BETA_JAVA24
Are you sure you want to change the base?
Conversation
@@ -214,7 +214,7 @@ public static void checkASTLevel(int level) { | |||
private static final String[] AST_COMPLIANCE_MAP = {"-1","-1",JavaCore.VERSION_1_2, JavaCore.VERSION_1_3, JavaCore.VERSION_1_7, //$NON-NLS-1$ //$NON-NLS-2$ | |||
JavaCore.VERSION_1_7, JavaCore.VERSION_1_7, JavaCore.VERSION_1_7, JavaCore.VERSION_1_8, JavaCore.VERSION_9, JavaCore.VERSION_10, | |||
JavaCore.VERSION_11, JavaCore.VERSION_12, JavaCore.VERSION_13, JavaCore.VERSION_14, JavaCore.VERSION_15, JavaCore.VERSION_16, JavaCore.VERSION_17, JavaCore.VERSION_18, | |||
JavaCore.VERSION_19, JavaCore.VERSION_20, JavaCore.VERSION_21, JavaCore.VERSION_22, JavaCore.VERSION_23}; | |||
JavaCore.VERSION_19, JavaCore.VERSION_20, JavaCore.VERSION_21, JavaCore.VERSION_22, JavaCore.VERSION_23, JavaCore.VERSION_23}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this be VERSION_24?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, thanks. Will fix it.
2fa5594
to
683b26f
Compare
launcher.setVMArguments(new String[]{"-verify"}); | ||
long vmVersion = Util.getMajorMinorVMVersion(); | ||
if (vmVersion < ClassFileConstants.JDK24) { | ||
launcher.setVMArguments(new String[]{"-verify"}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is option -verify
being removed, or what kind of trouble does it cause?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not yet but will cause tons of tests to fail with this warning. We need a strategy if we continue to require this by our tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not yet but will cause tons of tests to fail with this warning. We need a strategy if we continue to require this by our tests.
Are you saying this from experience with previous versions, or is anything becoming stricter specifically in 24?
I'm just curious what could make classfiles generated by ecj fail the VM's verification?
What it does
Fixes #2905
How to test
Author checklist