Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip the method PluginsTab::performApply until after activation #1252

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Skip the method PluginsTab::performApply until after activation #1252

wants to merge 1 commit into from

Commits on Sep 11, 2024

  1. Skip the method PluginsTab::performApply until after activation 

    If this method (or part of it) is run before the tab has been activated
then the default configuration passed as parameter will be modified and
incorrect values will be introduced.

Remove attributes in PDE launch configurations instead of explicitly
setting them to their default values

The attributes in  question are:
- DESELECTED_WORKSPACE_BUNDLES --> []
- USE_CUSTOM_FEATURES --> false
- SHOW_SELECTED_ONLY --> false
- INCLUDE_OPTIONAL --> true
- AUTOMATIC_ADD --> true

The reason to do this is that 2 launch configurations are considered
different if one of them explicitly sets an attribute to its default
value (because it then has 1 more attribute)

This commit fixes a regression introduced in
98a5865

Fixes eclipse-pde#1250
    @fedejeanne
    fedejeanne committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    1cdde48 View commit details
    Browse the repository at this point in the history