Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add overwritable indirection for flag to skip version baseline check #2381

Conversation

HannesWell
Copy link
Member

This can for example be used in eclipse-jdt/eclipse.jdt.core#2994 and can be applied to future version-baseline check mojos that are probably necessary for

HannesWell added a commit to HannesWell/eclipse.jdt.core that referenced this pull request Sep 23, 2024
Most parts of the configuration are already inherited from the
'eclipse-platform-parent'.
And leverage the new overwritable property to permanently disable the
baseline check, which is introduced in
eclipse-platform/eclipse.platform.releng.aggregator#2381
@akurtakov
Copy link
Member

Heap memory issue which shouldn't be related to this change. Merging.

@akurtakov akurtakov merged commit bf9f48f into eclipse-platform:master Sep 24, 2024
3 of 4 checks passed
akurtakov pushed a commit to HannesWell/eclipse.jdt.core that referenced this pull request Sep 24, 2024
Most parts of the configuration are already inherited from the
'eclipse-platform-parent'.
And leverage the new overwritable property to permanently disable the
baseline check, which is introduced in
eclipse-platform/eclipse.platform.releng.aggregator#2381
@HannesWell HannesWell deleted the overwriteable-baseline-check-switch branch September 24, 2024 17:34
akurtakov pushed a commit to HannesWell/eclipse.jdt.core that referenced this pull request Sep 26, 2024
Most parts of the configuration are already inherited from the
'eclipse-platform-parent'.
And leverage the new overwritable property to permanently disable the
baseline check, which is introduced in
eclipse-platform/eclipse.platform.releng.aggregator#2381
akurtakov pushed a commit to eclipse-jdt/eclipse.jdt.core that referenced this pull request Sep 27, 2024
Most parts of the configuration are already inherited from the
'eclipse-platform-parent'.
And leverage the new overwritable property to permanently disable the
baseline check, which is introduced in
eclipse-platform/eclipse.platform.releng.aggregator#2381
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants