Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initialize the ProjectPreferences with the workspace #126

Merged
merged 1 commit into from
May 11, 2022
Merged

Initialize the ProjectPreferences with the workspace #126

merged 1 commit into from
May 11, 2022

Conversation

laeubi
Copy link
Contributor

@laeubi laeubi commented May 10, 2022 •
edited
Loading

This makes the current Workspace visible to the ProjectPreferences right
after we change the search order.

Beside that, the workspace is passed / fetched from known sources if
possible

Fix #124
Blocks #71

@eclipse-releng-bot
Copy link
Contributor

The Jenkins build of this PR has now completed. See details at https://ci.eclipse.org/platform/job/eclipse.platform.resources/job/PR-126/1/

@eclipse-releng-bot
Copy link
Contributor

The Jenkins build of this PR has now completed. See details at https://ci.eclipse.org/platform/job/eclipse.platform.resources/job/PR-126/2/

@eclipse-releng-bot
Copy link
Contributor

The Jenkins build of this PR has now completed. See details at https://ci.eclipse.org/platform/job/eclipse.platform.resources/job/PR-126/3/

@laeubi
Copy link
Contributor Author

laeubi commented May 11, 2022

I have now added a error thrown if the preferences are not of the expected type.

@eclipse-releng-bot
Copy link
Contributor

The Jenkins build of this PR has now completed. See details at https://ci.eclipse.org/platform/job/eclipse.platform.resources/job/PR-126/4/

iloveeclipse
iloveeclipse requested changes May 11, 2022
View reviewed changes
Copy link
Member

@iloveeclipse iloveeclipse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please with next change squash everything in one commit before pushing.

bundles/org.eclipse.core.resources/src/org/eclipse/core/internal/resources/Workspace.java Show resolved Hide resolved
@eclipse-releng-bot
Copy link
Contributor

The Jenkins build of this PR has now completed. See details at https://ci.eclipse.org/platform/job/eclipse.platform.resources/job/PR-126/5/

@laeubi laeubi requested a review from iloveeclipse May 11, 2022 14:01
@eclipse-releng-bot
Copy link
Contributor

The Jenkins build of this PR has now completed. See details at https://ci.eclipse.org/platform/job/eclipse.platform.resources/job/PR-126/6/

@laeubi
Initialize the ProjectPreferences with the workspace
74d0c56 
This makes the current Workspace visible to the ProjectPreferences right
after we change the search order.

Beside that, the workspace is passed / fetched from known sources if
possible

Fix eclipse-platform#124
@eclipse-releng-bot
Copy link
Contributor

The Jenkins build of this PR has now completed. See details at https://ci.eclipse.org/platform/job/eclipse.platform.resources/job/PR-126/7/

iloveeclipse
iloveeclipse approved these changes May 11, 2022
View reviewed changes
Copy link
Member

@iloveeclipse iloveeclipse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@iloveeclipse iloveeclipse merged commit e46b1aa into eclipse-platform:master May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iloveeclipse iloveeclipse iloveeclipse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CharsetManager might early access the ResourcesPlugin.getWorkspace
3 participants
@laeubi @eclipse-releng-bot @iloveeclipse