Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Image for storing ImageMetadata #1496

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

amartya4256
Copy link
Contributor

@amartya4256 amartya4256 commented Sep 26, 2024

This PR contributes to the refactoring of Image class for win32. The goal is to encapsulate the metadata in ImageMeadata class and store imageMetadata for each zoom level for every image instead of zoom level to handle. This way we obtain the imagedata for every image at different zoom by calling the metadata object for that zoom level.

contributes to #62 and #127

Copy link
Contributor

github-actions bot commented Sep 26, 2024

Test Results

   476 files   - 10     476 suites   - 10   8m 25s ⏱️ +6s
 4 159 tests ± 0   4 151 ✅ ± 0   8 💤 ±0  0 ❌ ±0 
16 390 runs  ± 0  16 298 ✅ ± 0  92 💤 ±0  0 ❌ ±0 

Results for commit e353b1a. ± Comparison against base commit ebe6ec4.

♻️ This comment has been updated with latest results.

This contribution encapsulates the metadata of the image in an
innerclass ImageMetadata which is used to create a hashmap of zoom level
to imageMetadata object inside an image object, making it straight
forward to obtain any metadata information from an image for a zoom
level.

contributes to eclipse-platform#62 and eclipse-platform#127
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant