use ScreenshotOnFailure TestWatcher

eclipse-platform · Sep 30, 2024 · c3de0e7 · c3de0e7
1 parent 8a8979f
commit c3de0e7
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 30 deletions.
diff --git a/...g.eclipse.e4.ui.tests/src/org/eclipse/e4/ui/tests/workbench/PartRenderingEngineTests.java b/...g.eclipse.e4.ui.tests/src/org/eclipse/e4/ui/tests/workbench/PartRenderingEngineTests.java
@@ -71,6 +71,7 @@
 import org.junit.Rule;
 import org.junit.Test;
 import org.junit.rules.TestName;
+import org.junit.rules.TestWatcher;
 import org.osgi.service.log.LogLevel;
 import org.osgi.service.log.LogListener;
 import org.osgi.service.log.LogReaderService;
@@ -2972,6 +2973,9 @@ public void testBug371100() {
 		assertFalse(logged);
 	}
 
+	@Rule
+	public TestWatcher screenshotRule = Screenshots.onFailure();
+
 	@Test
 	public void testBug372226() {
 		assumeFalse("Test fails on Mac: Bug 537639", Platform.OS_MACOSX.equals(Platform.getOS()));
@@ -2991,8 +2995,6 @@ public void testBug372226() {
 		Control control = (Control) part.getWidget();
 		assertEquals(subShell, control.getParent());
 
-		Screenshots.takeScreenshot(getClass(), testName.getMethodName());
-
 		appContext.get(EPartService.class).activate(part);
 		assertEquals(subShell, control.getParent());
 	}

diff --git a/...rg.eclipse.jface.text.tests/src/org/eclipse/jface/text/tests/ScreenshotOnFailureRule.java b/...rg.eclipse.jface.text.tests/src/org/eclipse/jface/text/tests/ScreenshotOnFailureRule.java
diff --git a/tests/org.eclipse.jface.text.tests/src/org/eclipse/jface/text/tests/TextViewerTest.java b/tests/org.eclipse.jface.text.tests/src/org/eclipse/jface/text/tests/TextViewerTest.java
@@ -28,6 +28,9 @@
 import org.junit.Assume;
 import org.junit.Rule;
 import org.junit.Test;
+import org.junit.rules.TestWatcher;
+
+import org.eclipse.test.Screenshots;
 
 import org.eclipse.swt.SWT;
 import org.eclipse.swt.custom.StyledText;
@@ -73,7 +76,9 @@
  */
 public class TextViewerTest {
 
-	@Rule public ScreenshotOnFailureRule screenshotRule = new ScreenshotOnFailureRule();
+	@Rule
+	public TestWatcher screenshotRule= Screenshots.onFailure();
+
 	private Shell fShell;
 
 	@After

diff --git a/....eclipse.jface.text.tests/src/org/eclipse/jface/text/tests/codemining/CodeMiningTest.java b/....eclipse.jface.text.tests/src/org/eclipse/jface/text/tests/codemining/CodeMiningTest.java
@@ -25,6 +25,9 @@
 import org.junit.Before;
 import org.junit.Rule;
 import org.junit.Test;
+import org.junit.rules.TestWatcher;
+
+import org.eclipse.test.Screenshots;
 
 import org.eclipse.swt.SWT;
 import org.eclipse.swt.custom.StyleRange;
@@ -57,7 +60,6 @@
 import org.eclipse.jface.text.source.AnnotationModel;
 import org.eclipse.jface.text.source.AnnotationPainter;
 import org.eclipse.jface.text.source.SourceViewer;
-import org.eclipse.jface.text.tests.ScreenshotOnFailureRule;
 import org.eclipse.jface.text.tests.TextViewerTest;
 import org.eclipse.jface.text.tests.util.DisplayHelper;
 
@@ -66,7 +68,8 @@ public class CodeMiningTest {
 	private SourceViewer fViewer;
 	private Shell fShell;
 
-	@Rule public ScreenshotOnFailureRule rule = new ScreenshotOnFailureRule();
+	@Rule
+	public TestWatcher screenshotRule= Screenshots.onFailure();
 
 	@Before
 	public void setUp() {