Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EXPERIMENT: display the Find/Replace overlay as partstack #2234

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Wittmaxi
Copy link
Contributor

@Wittmaxi Wittmaxi commented Sep 2, 2024

Experiment with display the Find/Replace Overlay as a Part in a Partstack instead of an overlay shell.

Caveats:

  • the part has the annoying tendency to stick to the side instead of allowing to be "positionned to the top all the time"
  • keypresses are still interpreted as keypresses targeted towards the Editor behind (ie. pressing Ctrl+Backspace delets a full word in the editor not in the overlay)

First time opening the overlay (something is wrong...)
grafik

Second time pressing Cltr+F
grafik

Adapted from #2093

I do not believe that this solution can bring improvement to #2099

@Wittmaxi Wittmaxi marked this pull request as draft September 2, 2024 12:59
Copy link
Contributor

github-actions bot commented Sep 2, 2024

Test Results

0 files   -  1 815  0 suites   - 1 815   0s ⏱️ - 1h 37m 11s
0 tests  -  7 696  0 ✅  -  7 468  0 💤  - 228  0 ❌ ±0 
0 runs   - 24 249  0 ✅  - 23 500  0 💤  - 749  0 ❌ ±0 

Results for commit 4f8aac4. ± Comparison against base commit b96413b.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant