-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Not run link handler registration in test execution #2306
base: master
Are you sure you want to change the base?
Not run link handler registration in test execution #2306
Conversation
This PR depends on #2302 |
Test Results 1 815 files ±0 1 815 suites ±0 1h 40m 48s ⏱️ + 4m 15s For more details on these failures, see this check. Results for commit f9ba59b. ± Comparison against base commit 0986115. ♻️ This comment has been updated with latest results. |
If the IDE is running because we are executing automated tests it doesn't make sense to run this registration job. Fixes : eclipse-platform#2245
6b86521
to
f9ba59b
Compare
@jukzi: Are the log entries in the test execution now gone for this PR? |
i am not sure what you asking.
but its only in the i-build not tested for every PR |
I thought it's also visible in PR-builds. So we have to merge this and have a look into the next i-build |
String application = envInfo.getProperty("eclipse.application"); //$NON-NLS-1$ | ||
result.set(application != null && Set.of( // | ||
// see org.eclipse.pde.internal.launching.IPDEConstants | ||
"org.eclipse.pde.junit.runtime.nonuithreadtestapplication", // //$NON-NLS-1$ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sratz: from the i-build's log
https://download.eclipse.org/eclipse/downloads/drops4/I20240923-1800/testresults/ep434I-unit-mac64-java17_macosx.cocoa.x86_64_17/org.eclipse.debug.tests.AutomatedSuite.txt
i see
Framework arguments: -application org.eclipse.test.uitestapplication formatter=...
So it looks like org.eclipse.test.uitestapplication
is used. Is it missing in this list?
No description provided.