Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct output and source specifications in build.properties #871

Merged
merged 2 commits into from
Nov 28, 2023
Merged

Correct output and source specifications in build.properties #871

merged 2 commits into from
Nov 28, 2023

Conversation

HeikoKlare
Copy link
Contributor

@HeikoKlare HeikoKlare commented Nov 21, 2023 •
edited
Loading

  • Remove source entries in projects without source folders
  • Remove duplicate source entries
  • Add missing output entries
  • Fix project classpaths with unseparated bin folders and adapt .gitignore

@HeikoKlare HeikoKlare force-pushed the fix-build-properties branch 3 times, most recently from ab4a3f8 to 444d75a Compare November 21, 2023 14:10
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 21, 2023 •
edited
Loading

Test Results

     591 files  +   123       591 suites  +123   1h 4m 25s ⏱️ + 14m 45s
  3 837 tests +   376    3 832 ✔️ +   377    5 💤 ±0  0 ❌ ±0 
12 117 runs  +1 128  12 081 ✔️ +1 129  36 💤 ±0  0 ❌ ±0 

Results for commit 2c5cffd. ± Comparison against base commit d5595f7.

♻️ This comment has been updated with latest results.

@HeikoKlare HeikoKlare marked this pull request as ready for review November 21, 2023 14:45
@HeikoKlare HeikoKlare mentioned this pull request Nov 21, 2023
Merged
@jukzi
Copy link
Contributor

jukzi commented Nov 22, 2023

Thanks, we need such for all repositories.

@HeikoKlare
Copy link
Contributor Author

Thanks, we need such for all repositories

I can go through other repositories whenever I find time to do so. Seems that currently this repository is the most affected one, as builds for PRs in other repos like Platform UI and SWT do not fail, so it should not be as urgent for those repositories as it is for this one, right?

@jukzi
Copy link
Contributor

jukzi commented Nov 22, 2023

All repositories are failing, just depends which projects are changed. It's best seen on bulk changes like eclipse-platform/eclipse.platform.ui#1287

@HeikoKlare
Copy link
Contributor Author

All repositories are failing, just depends which projects are changed. It's best seen on bulk changes like eclipse-platform/eclipse.platform.ui#1287

I see. I drafted a PR for Platform UI: eclipse-platform/eclipse.platform.ui#1321

@HeikoKlare HeikoKlare mentioned this pull request Nov 22, 2023
Merged
@HeikoKlare HeikoKlare force-pushed the fix-build-properties branch 2 times, most recently from 45dcb55 to f988bf6 Compare November 27, 2023 07:01
@akurtakov akurtakov mentioned this pull request Nov 28, 2023
Merged
@HeikoKlare
Correct output and source specifications in build.properties
ca5a577 
* Remove source entries in projects without source folders
* Remove duplicate source entries
* Add missing output entries
* Fix project classpaths with unseparated bin folders and adapt
.gitignore
@HeikoKlare HeikoKlare force-pushed the fix-build-properties branch 3 times, most recently from e047f0a to db98087 Compare November 28, 2023 19:03
@HeikoKlare HeikoKlare merged commit 05d6dea into eclipse-platform:master Nov 28, 2023
16 checks passed
@HeikoKlare HeikoKlare deleted the fix-build-properties branch November 28, 2023 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jukzi jukzi jukzi left review comments

@fedejeanne fedejeanne fedejeanne approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HeikoKlare @jukzi @fedejeanne