GH-5053: avoid log spam for configurations class with legacy settings #5077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When there is only a value for the legacy setting (i.e. the new config setting is not used) we now log on level debug. Otherwise on warn. The rational is: when users still have persisted legacy repository configurations, the log is easily spammed with warnings.
hmottestad
approved these changes
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub issue resolved: #5053
When there is only a value for the legacy setting (i.e. the new config setting is not used) we now log on level debug. Otherwise on warn.
The rational is: when users still have persisted legacy repository configurations, the log is easily spammed with warnings.
PR Author Checklist (see the contributor guidelines for more details):
mvn process-resourcesto format from the command line)