Updated docker base image to node:18-bullseye in browser.Dockerfile #346
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Resolves #345
node:16-bullseye
seems outdated and resulted in the bug documented in the above issue. It is not currently supported on the official list of node docker images: https://hub.docker.com/_/nodeThe issue at #345 was resolved even by changing to
node:18-bullseye
only in thebuild-stage
, but presumably it should be already upgraded also in theproduction-stage
, so this commit/PR also updates the production stage based image.How to test
Following/repeating the instructions here: #345
git clone https://github.com/eclipse-theia/theia-blueprint
cd theia-blueprint
docker build -t theia-ide -f browser.Dockerfile .
(like instructed here)docker build
command failure documented in issue #345. But I am relying on the core development team to consider how and whether/when such an upgrade fits with the rest of the development process.Review checklist
Reminder for reviewers