fix: use more specific locators for dialog buttons in playwright tests

Contributed on behalf of STMicroelectronics Signed-off-by: Olaf Lessenich <[email protected]>
eclipse-theia · Aug 29, 2023 · ad81bb8 · ad81bb8
1 parent a5b5d28
commit ad81bb8
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/examples/playwright/src/tests/theia-electron-app.test.ts b/examples/playwright/src/tests/theia-electron-app.test.ts
@@ -65,7 +65,7 @@ test.describe('Theia Electron Application', () => {
         await (await menuBar.openMenu('File')).clickMenuItem('Open File...');
         const fileDialog = await app.page.waitForSelector('div[class="dialogBlock"]');
         expect(await fileDialog.isVisible()).toBe(true);
-        await app.page.getByRole('button', { name: 'Cancel' }).click();
+        await app.page.locator('#theia-dialog-shell').getByRole('button', { name: 'Cancel' }).click();
         expect(await fileDialog.isVisible()).toBe(false);
     });
 
@@ -79,7 +79,7 @@ test.describe('Theia Electron Application', () => {
 
         const fileEntry = app.page.getByText('sample.txt');
         await fileEntry.click();
-        await app.page.getByRole('button', { name: 'Open' }).click();
+        await app.page.locator('#theia-dialog-shell').getByRole('button', { name: 'Open' }).click();
 
         const span = await app.page.waitForSelector('span:has-text("content line 2")');
         expect(await span.isVisible()).toBe(true);

diff --git a/examples/playwright/src/tests/theia-workspace.test.ts b/examples/playwright/src/tests/theia-workspace.test.ts
@@ -61,7 +61,7 @@ test.describe('Theia Workspace', () => {
 
         const fileEntry = app.page.getByText('sample.txt');
         await fileEntry.click();
-        await app.page.getByRole('button', { name: 'Open' }).click();
+        await app.page.locator('#theia-dialog-shell').getByRole('button', { name: 'Open' }).click();
 
         const span = await app.page.waitForSelector('span:has-text("content line 2")');
         expect(await span.isVisible()).toBe(true);