Skip to content

Commit

Permalink
Fix an API test failure on macOS
Browse files Browse the repository at this point in the history
Before this fix, Monaco API KeybindingService.resolveKeybinding test was failing
on macOS with

```
AssertionError: expected { label: '⌃⇧⌥⌘K', …(6) } to deeply equal { label: '⌃⇧⌥⌘K', …(7) }
+ expected - actual

{
 "WYSIWYG": true
 "ariaLabel": "⌃⇧⌥⌘K"
+  "chord": false
 "dispatchParts": [
   "ctrl+shift+alt+meta+K"
 ]
 "electronAccelerator": "Ctrl+Shift+Alt+Cmd+K"
```

The `chord: false` was removed from the expected object for other platforms
as part of #13217.

This fix removes it from the expected object for macOS.
  • Loading branch information
pisv committed May 26, 2024
1 parent 3dc5537 commit b7ae53a
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion examples/api-tests/src/monaco-api.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,6 @@ describe('Monaco API', async function () {
electronAccelerator: 'Ctrl+Shift+Alt+Cmd+K',
userSettingsLabel: 'ctrl+shift+alt+cmd+K',
WYSIWYG: true,
chord: false,
parts: [new ResolvedChord(
true,
true,
Expand Down

0 comments on commit b7ae53a

Please sign in to comment.