Skip to content

Commit

Permalink
Adapt position shown to the user for the link to 1-based monaco position
Browse files Browse the repository at this point in the history
  • Loading branch information
rschnekenbu committed Sep 23, 2024
1 parent a3af47d commit fd2dd2e
Showing 1 changed file with 6 additions and 2 deletions.
8 changes: 6 additions & 2 deletions packages/test/src/browser/view/test-result-widget.ts
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ import { URI } from '@theia/core/lib/common/uri';
import { FileService } from '@theia/filesystem/lib/browser/file-service';
import { NavigationLocationService } from '@theia/editor/lib/browser/navigation/navigation-location-service';
import { NavigationLocation, Position } from '@theia/editor/lib/browser/navigation/navigation-location';

@injectable()
export class TestResultWidget extends BaseWidget {

Expand Down Expand Up @@ -113,7 +112,12 @@ export class TestResultWidget extends BaseWidget {
const link = this.node.ownerDocument.createElement('a');
let content = `${this.labelProvider.getName(uri)}`;
if (stackFrame.position) {
content += `:${stackFrame.position.line}:${stackFrame.position.character}`;
// Display Position as a 1-based position, similar to Monaco ones.
const monacoPosition = {
lineNumber: stackFrame.position.line + 1,
column: stackFrame.position.character + 1
};
content += `:${monacoPosition.lineNumber}:${monacoPosition.column}`;
}
link.textContent = content;
link.href = `${uri}`;
Expand Down

0 comments on commit fd2dd2e

Please sign in to comment.