Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delegate showing help to the back end process. #13729

Merged
merged 1 commit into from
May 28, 2024

Conversation

tsmaeder
Copy link
Contributor

What it does

Fixes #13727

The approach is to add non-functional cli contributions for any arguments that concern only the electron-main process. Currently, we have a bit of confusion between the theia cli tool, which is mostly a development-time tool (theia build, etc.) and the actual Theia application executable (TheiaIde.exe). It would probably make sense to evolve the architecture in a way that all possible command line options are available to all "customer-facing" cli tools and can be selectively forwarded to the back-end, plugin-process and any other processes making up Theia.

Contributed on behalf of STMicroelectronics

How to test

The closest equivalent to what the TheiaIDE.exe does is the "Launch electron back end" launch configuration. To test, you can add parameters after the initial . parameter (which is a parameter to Electron). One can also use npx theia start <...params> on the command line in the electron or browser example.
In these way, test that the help commands output reasonable advice and that start parameters are properly handled.

Follow-ups

Review checklist

Reminder for reviewers

Fixes eclipse-theia#13727

The approach is to add non-functional cli contributions for any
arguments that concern only the electron-main process.

Contributed on behalf of STMicroelectronics

Signed-off-by: Thomas Mäder <[email protected]>
@msujew msujew added the electron issues related to the electron target label May 28, 2024
Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

I'm getting a bit of superfluous output before the --help command, but similarly to the server case, there's probably no easy way around this:

Showing splash screen
SplashScreen options { content: 'resources/theia-logo.svg', height: 90 }

@tsmaeder tsmaeder merged commit b358fd7 into eclipse-theia:master May 28, 2024
14 checks passed
@jfaltermeier jfaltermeier added this to the 1.50.0 milestone Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
electron issues related to the electron target
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Bogus help message from Theia Electron Main
3 participants