Delegate showing help to the back end process. #13729
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Fixes #13727
The approach is to add non-functional cli contributions for any arguments that concern only the electron-main process. Currently, we have a bit of confusion between the
theia
cli tool, which is mostly a development-time tool (theia build
, etc.) and the actual Theia application executable (TheiaIde.exe
). It would probably make sense to evolve the architecture in a way that all possible command line options are available to all "customer-facing" cli tools and can be selectively forwarded to the back-end, plugin-process and any other processes making up Theia.Contributed on behalf of STMicroelectronics
How to test
The closest equivalent to what the
TheiaIDE.exe
does is the "Launch electron back end" launch configuration. To test, you can add parameters after the initial.
parameter (which is a parameter to Electron). One can also usenpx theia start <...params>
on the command line in the electron or browser example.In these way, test that the help commands output reasonable advice and that start parameters are properly handled.
Follow-ups
Review checklist
Reminder for reviewers