Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix quick pick separators from plugins #13740

Merged
merged 1 commit into from
May 29, 2024

Conversation

msujew
Copy link
Member

@msujew msujew commented May 29, 2024

What it does

Closes #13739

Adds the correct code to convert quick pick separators from plugins to quick pick separators in Theia's frontend.

How to test

See #13739 for reproduction steps and assert that the separators are displayed just like in VSCode.

Review checklist

Reminder for reviewers

@msujew msujew added vscode issues related to VSCode compatibility quick-open issues related to the quick-open labels May 29, 2024
@msujew msujew requested a review from jonah-iden May 29, 2024 13:25
Copy link
Contributor

@jonah-iden jonah-iden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great 👍

@msujew msujew merged commit c1e941e into master May 29, 2024
14 checks passed
@msujew msujew deleted the msujew/plugin-quick-pick-separators branch May 29, 2024 15:00
@github-actions github-actions bot added this to the 1.50.0 milestone May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
quick-open issues related to the quick-open vscode issues related to VSCode compatibility
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Plugin quick picks show separators as items
2 participants