Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve dev-container label #13744

Merged

Conversation

planger
Copy link
Contributor

@planger planger commented May 29, 2024

What it does

If a container name was specified in the devcontainer, use it in the label of the status bar.

How to test

Specify a devcontainer file, assign a label and reopen it in the container. Check the status bar entry.

Follow-ups

N/A

Review checklist

Reminder for reviewers

Change-Id: I1bb27d0caea9f8a72bbdc2fa5a8dc7ee13bd807b
@planger planger requested a review from jonah-iden May 29, 2024 15:19
@planger planger added the remote issues related to the remote functionality label May 29, 2024
Copy link
Contributor

@jonah-iden jonah-iden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works nicely and Code looks good

@planger planger added this to the 1.50.0 milestone May 31, 2024
@planger planger merged commit 0941a8f into eclipse-theia:master May 31, 2024
13 of 14 checks passed
@planger planger deleted the improve-dev-container-label branch May 31, 2024 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
remote issues related to the remote functionality
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants