Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved Upload Command #13775

Merged
merged 1 commit into from
Jun 6, 2024
Merged

Improved Upload Command #13775

merged 1 commit into from
Jun 6, 2024

Conversation

jonah-iden
Copy link
Contributor

What it does

Closes #5739

Upload files command is now always visible in the browser.

  • if nothing is selected uploads to the workspace root
  • if a folder is selected uploads to that folder
  • if a file is selected uploads to the parent folder

This seemed like the most intuitive way for me.

How to test

  1. Start theia as browser
  2. Either right click in the navigator or use the file menu
  3. upload a file with different selections, see description above

Follow-ups

Review checklist

Reminder for reviewers

- if nothing is selected uploads to the workspace root
- if a folder is selected uploads to that folder
- if a file is selected uploads to the parent folder

Signed-off-by: Jonah Iden <[email protected]>
@jonah-iden jonah-iden requested a review from msujew June 6, 2024 09:31
Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jonah-iden jonah-iden merged commit a3c8906 into master Jun 6, 2024
14 checks passed
@jonah-iden jonah-iden deleted the jiden/better-file-upload branch June 6, 2024 10:03
@github-actions github-actions bot added this to the 1.51.0 milestone Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

File > Upload Files... should always be enabled + always upload into workspace root
2 participants