Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an indicator for loading notebooks #13843

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

msujew
Copy link
Member

@msujew msujew commented Jun 25, 2024

What it does

Adds a small loading indicator for notebook widgets. While the notebook is loading (which might include activating the corresponding extension and waiting until the notebook serializer is ready), we simply display the indicator to make it clear that the notebook is still loading.

How to test

  1. Open a notebook
  2. Assert that for a short duration, the indicator is visible at the top of the widget.

Review checklist

Reminder for reviewers

@msujew msujew added ui/ux issues related to user interface / user experience notebook issues related to notebooks labels Jun 25, 2024
@msujew msujew requested a review from jonah-iden June 25, 2024 13:44
Copy link
Contributor

@jonah-iden jonah-iden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Great. Thanks!

@msujew msujew merged commit 37e1f2c into master Jun 26, 2024
13 of 14 checks passed
@msujew msujew deleted the msujew/notebook-loading-indicator branch June 26, 2024 09:34
@github-actions github-actions bot added this to the 1.51.0 milestone Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
notebook issues related to notebooks ui/ux issues related to user interface / user experience
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants