Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure notebook model created when calling openNotebookDocument #14029

Merged
merged 1 commit into from
Aug 9, 2024

Conversation

dhuebner
Copy link
Contributor

@dhuebner dhuebner commented Aug 9, 2024

What it does

Fixes a bogus behavior when executing openNotebookDocument().
openNotebookDocument should create a NotebookModel (Document) so that a later call of e.g. showNotebookDocument() is able to open a new editor.
A use case is e.g. when you open a notebook file in a text editor and then use Open in Notebook Editor link in this text editor. Before this change text editor will be closed, but no new notebook editor will open.

How to test

In Explorer use "Open with..." to open a notebook file with a text editor use. If notebook extension is running "Open in Notebook Editor" link should become visible in the editor.
Bildschirmfoto 2024-08-09 um 11 41 23

Clicking this link should open a new Notebook editor.

Follow-ups

Review checklist

Reminder for reviewers

Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@msujew msujew added the notebook issues related to notebooks label Aug 9, 2024
@msujew msujew merged commit 44d42ec into eclipse-theia:master Aug 9, 2024
11 of 14 checks passed
@jfaltermeier jfaltermeier added this to the 1.53.0 milestone Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
notebook issues related to notebooks
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants