Fix FileResource sometimes sending contents change event during writing #14043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
event during writing Add a lock to the write operation so that checking if the file is synced must wait for the write operation to be done. Fixes eclipse-theia#14021 Contributed on behalf of Toro Cloud Signed-off-by: Vivien Jovet <[email protected]>
Hanksha
force-pushed
the
gh-14021-fix-file-resource-event
branch
from
36f7304
to
c3c3456
Compare
|
@msujew Do you want to merge this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
This PR adds a lock to the write operations of the
FileResource(doWriteanddoSaveContentChanges) so that if a change event is received from theFileServiceit must wait for the writing to be done (which sets the up to dateversion) before to check if the file is synced (which involves resolving it and checking themtime).Fixes #14021
Contributed on behalf of Toro Cloud
How to test
I added a unit test at packages/filesystem/src/browser/file-resource.spec.ts that can be used to check the behavior. Alternatively you can follow the steps to reproduce described here and see if you cannot reproduce it anymore.
Follow-ups
Review checklist
Reminder for reviewers