Fix enablement of AI support #14166
Merged
Fix enablement of AI support #14166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonasHelming
approved these changes
Sep 15, 2024
|
Also I did not find any other UI contributions, so this PR closes #14167 |
sdirix
force-pushed
the
fix-ai-agent
branch
from
e700392
to
5ef92ee
Compare
The ai-core package offers a preference context key, which can be used in scenarios like 'when' clauses for menus. This key was not integrated, leading to the deactivation of all dependent features. This is now fixed.
sdirix
force-pushed
the
fix-ai-agent
branch
from
5ef92ee
to
716c03b
Compare
planger
changed the title
|
I updated the PR to fix the root cause of the issue 👍 |
|
@sdirix Does this now also fix the issue I described (the follow up Philip mentioned) |
Yes, that is fixed too 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
The 'ai-core' package offers a preference context key, which is for example used in 'when' clauses for the AI terminal menu entries.
Due to an oversight in the AI contribution refactorings, this context key was never enabled. Therefore the Terminal AI support didn't show up anymore, even if the experimental AI support was enabled via the preferences. Neither the context menu nor the keyboard shortcut (Ctrl-I) was working.
This is now fixed
How to test
Ensure the AI experimental setting is enabled
Open a terminal view
Check that "Ask the AI" shows up in the context menu of the Terminal
Check that Ctrl-I enables the assistant
Disable the AI experimental setting
Check that "Ask the AI" doesn't show up in the context menu of the Terminal
Check that Ctrl-I does not enable the assistant
Follow-ups
N/A
Review checklist
Reminder for reviewers