Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Focus notebook cell container correctly #14175

Merged
merged 1 commit into from
Sep 16, 2024
Merged

Conversation

msujew
Copy link
Member

@msujew msujew commented Sep 16, 2024

What it does

When using the "Jupyter Keymap" plugin, pressing B should trigger the notebook.cell.insertCodeCellBelowAndFocusContainer command. However, this command should not focus the newly inserted cell.

This change adjusts the behavior of the command to ensure that B can be pressed repeatedly to create new cells.

How to test

  1. Install the Jupyter Keymap plugin (comes with the Jupyter plugin)
  2. Open a notebook and focus a cell (but not the editor within)
  3. Press B to create a new cells below the current cell (or A to create one above)
  4. Ensure that the focus doesn't go to the text editor.
  5. Ensure that pressing the keybinding multiple times correctly creates a new cell each time.

Review checklist

Reminder for reviewers

@msujew msujew added keybindings issues related to keybindings notebook issues related to notebooks labels Sep 16, 2024
Copy link
Contributor

@jonah-iden jonah-iden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Loogs good 👍

@msujew msujew merged commit d167d1e into master Sep 16, 2024
11 checks passed
@msujew msujew deleted the msujew/focus-container-command branch September 16, 2024 16:40
@github-actions github-actions bot added this to the 1.54.0 milestone Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keybindings issues related to keybindings notebook issues related to notebooks
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants