Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Closes #14178
Adds a
tabIndex
to one of the rendered html nodes of the notebook editor. This ensures that the context key service can find the correct active element when clicking on the toolbar button. If no focusable element is available, the browser will instead select thebody
element, which is linked to a different context.How to test
Follow the steps from #14178 and ensure that things work as expected.
Please also ensure/test that all context key related stuff still works - i.e.
j
/k
/up
/down
andy
/m
still work in command mode.Review checklist
Reminder for reviewers