Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix notebook context selection #14179

Merged
merged 1 commit into from
Sep 17, 2024
Merged

Fix notebook context selection #14179

merged 1 commit into from
Sep 17, 2024

Conversation

msujew
Copy link
Member

@msujew msujew commented Sep 16, 2024

What it does

Closes #14178

Adds a tabIndex to one of the rendered html nodes of the notebook editor. This ensures that the context key service can find the correct active element when clicking on the toolbar button. If no focusable element is available, the browser will instead select the body element, which is linked to a different context.

How to test

Follow the steps from #14178 and ensure that things work as expected.

Please also ensure/test that all context key related stuff still works - i.e. j/k/up/down and y/m still work in command mode.

Review checklist

Reminder for reviewers

@msujew msujew added the notebook issues related to notebooks label Sep 16, 2024
Copy link
Contributor

@jonah-iden jonah-iden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works 👍

@msujew msujew merged commit e1e6345 into master Sep 17, 2024
11 checks passed
@msujew msujew deleted the msujew/notebook-context branch September 17, 2024 08:51
@github-actions github-actions bot added this to the 1.54.0 milestone Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
notebook issues related to notebooks
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Main toolbar commands in notebook no longer working
2 participants