fix ai-settings retrieval #14221
Merged
fix ai-settings retrieval #14221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The languageModelRequirements can be undefined and this needs to be correcly handled by callers.
JonasHelming
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
The languageModelRequirements can be undefined and this needs to be correctly handled by callers.
How to test
Check that your settings have no entries for ai-agents. Now just disable an ai-agent using the ai configuration view. Now try to use this agent. See an error.
With the fix, the language model is correctly resolved to a default value.
Follow-ups
Review checklist
Reminder for reviewers